Skip to content

[WIP] refactor: enhance put/get string performance #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gxcsoccer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] refactor: enhance put/get string performance #31

gxcsoccer wants to merge 1 commit into from

Conversation

@gxcsoccer
Copy link
Member

@gxcsoccer gxcsoccer commented Dec 19, 2017

No description provided.

@gxcsoccer gxcsoccer requested a review from dead-horse December 19, 2017 07:10
@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017 •
edited
Loading

str 1k

const str = '1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234';

image

@fengmk2
Copy link
Member

fengmk2 commented Dec 19, 2017

@dead-horse 看看

@fengmk2
Copy link
Member

fengmk2 commented Dec 19, 2017

性能提升这么多

fengmk2
fengmk2 reviewed Dec 19, 2017
View reviewed changes
lib/byte.js Outdated
return this;
};

ByteBuffer.prototype.putUTFString = function (str) {
Copy link
Member

@fengmk2 fengmk2 Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释写一下？是utf8？

Copy link
Member Author

@gxcsoccer gxcsoccer Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

恩，我改成 UTF8

lib/byte.js
return this._bytes.toString('utf8', start, this._offset);
};

ByteBuffer.prototype.getRawStringFast = function (length) {
Copy link
Member

@fengmk2 fengmk2 Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么时候用fast？

Copy link
Member Author

@gxcsoccer gxcsoccer Dec 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试发现，当 length 小于 24 的时候 getRawStringByStringLength 是最快的，但是长字符串 getRawStringFast 还是有优势的

Copy link
Member Author

@gxcsoccer gxcsoccer Dec 19, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. hessian 里面 readType 的时候不可能出现 unicode 字符，所以直接用 getUTF8String
  2. 用 getRawStringFast 替代 getRawStringByStringLength
    • 当 length 小于 24 时（测试结果），降级为 getRawStringByStringLength
    • 当探测到 unicode 字符，则马上降级为 getRawStringByStringLength，因为认为一旦出现 unicode，一直出现 unicode 的几率比较高
    • 其余用新的逻辑

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

短字符串 getRawStringByStringLength 性能最好

const str = '12345678';

image

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

20 左右是一个拐点，getRawStringByStringLength 和 getRawStringFast 性能差不多

const str = '123456789012345678901';

image

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

str.length === 50

const str = '12345678901234567890123456789012345678901234567890';

image

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

长字符串（1k） getRawStringFast 会有优势

image

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

我找一个实际的类来测一下

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

实际测试效果不佳。。。

@gxcsoccer gxcsoccer changed the title refactor: enhance put/get string performance [WIP] refactor: enhance put/get string performance Dec 19, 2017
@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

大部分是 小于 20 的 str

@gxcsoccer
Copy link
Member Author

gxcsoccer commented Dec 19, 2017

搞郁闷了。。。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengmk2 fengmk2 fengmk2 left review comments

@dead-horse dead-horse Awaiting requested review from dead-horse

At least 1 approving review is required to merge this pull request.

Assignees

@fengmk2 fengmk2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gxcsoccer @fengmk2