Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue 89, point 32, original issue 716 #90

Closed
wants to merge 4 commits into from
Closed

Fixed issue 89, point 32, original issue 716 #90

wants to merge 4 commits into from

Conversation

FStefanni
Copy link
Contributor

@FStefanni FStefanni commented Nov 28, 2021 •
edited
Loading

Hi,

this is just a very minimal pr to fix the point number 32 of issue #89, matching the pr 716 in the original project.

Regards

@jorenvandeweyer
Copy link
Member

npm install is previously always done with node version < 16.

@FStefanni
Copy link
Contributor Author

Hi,

ok: tell me the preferred npm version and node version, and I'll fix this.

Regards

@FStefanni FStefanni mentioned this pull request Nov 28, 2021
Closed
33 tasks
@FStefanni
Copy link
Contributor Author

Hi,

rebased using:

  • node v14.18.1
  • npm 6.14.15

Regards.

@jankapunkt jankapunkt changed the base branch from master to development November 29, 2021 07:59
@HappyZombies
Copy link
Member

These changes are covered by dependabot so there's no need to open a new PR for these module updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FStefanni @jorenvandeweyer @HappyZombies