Correct missing generic type in useReplicantRaw#6
Open
Tempystral wants to merge 3 commits intonodecg:masterfrom
Open
Correct missing generic type in useReplicantRaw#6Tempystral wants to merge 3 commits intonodecg:masterfrom
useReplicantRaw#6Tempystral wants to merge 3 commits intonodecg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a bundle, I noticed the inferred generic type for a replicant was coming back as
unknownbecauseuseReplicantRawwithinuseReplicantwasn't using a generic typed call. Now it works!I don't love the hacky type stuff I had to do to get it to build... but looking at this, I'm not sure how it built at all before. I guess the NodeCG module has changed? It would be nice to have more direct access to stuff like
AssetFileandReplicant.Options. Still, it works.