Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator/orama-db): introduce #213

Merged

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Mar 18, 2025

This pull request introduces a new generator for creating an Orama database for the API documentation. The changes include adding new dependencies, importing and integrating the new generator, and implementing the generator logic.

close #65

Note

The output of v22.11.0 is 3Ko

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 18, 2025 09:21
@AugustinMauroy AugustinMauroy changed the title Add Orama db generator feat(generator/orama-db): introduce Mar 18, 2025
Co-Authored-By: Caner Akdas <[email protected]>
@flakey5
Copy link
Member

flakey5 commented Mar 18, 2025

One thing to note is we probably will want this to be updated to use the new json generator apis when that's introduced (will have the pr in a week or two ish). It also might just make sense to copy the used portions of the legacy json generator into the utils for this one, since I'm not sure what we're going to do with the legacy generators once we have the redesigned ones

@AugustinMauroy
Copy link
Member Author

Hummm intresting should I put this pr in draft or land it with legacy JSON ?

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member

ovflowd commented Mar 22, 2025

Hummm intresting should I put this pr in draft or land it with legacy JSON ?

We can merge as it is and create a follow-up task imo

@avivkeller avivkeller merged commit a691789 into main Mar 22, 2025
7 checks passed
@AugustinMauroy AugustinMauroy deleted the AugustinMauroy/augustinmauroy-workspace-generator-orama-db branch March 22, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add orama-db generator
6 participants