feat: add duplicate stability linters #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't ready to land, but it's good to have a mirror of the node core PR so that we make sure to land the same changes. (PS, sorry this wasn’t initially a draft, the GitHub UI gave out on me while trying to open this initially) |
avivkeller
changed the title
araujogui
reviewed
Mar 22, 2025
avivkeller
changed the title
|
@nodejs/web-infra @araujogui please (re-)review the lint changes. Thank you! |
avivkeller
commented
Mar 24, 2025
AugustinMauroy
approved these changes
Mar 24, 2025
flakey5
approved these changes
Mar 24, 2025
avivkeller
force-pushed
the
feat/stability-css
branch
from
57eccbf to
235cfc6
Compare
avivkeller
force-pushed
the
feat/stability-css
branch
from
b65f900 to
701b2b7
Compare
|
I changed the logic a little bit (to use the correct position), please re-review |
aduh95
reviewed
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the features that @aduh95 is adding in nodejs/node#57516.
(Note: I've added the "Blocked" label, as the original PR is yet to land)