Skip to content

chore(dep): remove useless dep #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented May 4, 2025

Description

Removing useless dep, we can just use node.

Validation

$npx api-docs-tooling generate  -i ../node/doc/api/*.md -t llms-txt -o out/
(node:15394) ExperimentalWarning: globSync is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Missing 'introduced_in' field in the API doc entry at doc/api/synopsis.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/async_context.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/esm.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/index.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/module.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/packages.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/synopsis.md
Missing llm_description field or paragraph node in the API doc entry at doc/api/typescript.md

Related Issues

No related issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • Run node --run test
  • Run node --run lint:fix; node --run format
  • NA I've covered new added functionality with unit tests if necessary.

@AugustinMauroy AugustinMauroy requested a review from a team as a code owner May 4, 2025 10:10
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried this before, but agreed not to use glob while it's still experimental

@AugustinMauroy
Copy link
Member Author

I don't see what the problem is with using this api, which is experimental but very stable.

@ovflowd
Copy link
Member

ovflowd commented May 4, 2025

I don't see what the problem is with using this api, which is experimental but very stable.

how can something experimental be stable. Also, we decided not so because otherwise you cannot run api-docs-tooling on older versions of Node...

@AugustinMauroy
Copy link
Member Author

how can something experimental be stable.

I mean there are not too much bug with it.

Also, we decided not so because otherwise you cannot run api-docs-tooling on older versions of Node...

Do we want that ? And what should the node supporter versions be?

@avivkeller
Copy link
Member

avivkeller commented May 4, 2025

For reference, as of now, The LTS versions are v20 and v22. v20 does not currently have glob.

@AugustinMauroy AugustinMauroy deleted the use-native-glob branch May 4, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants