fix: prevent grouping consecutive code blocks with the same language#667
fix: prevent grouping consecutive code blocks with the same language#667okuryu wants to merge 3 commits intonodejs:mainfrom
Conversation
Two consecutive code blocks with the same language (e.g., both `mjs`) were incorrectly grouped into a CJS/MJS switchable tab. Add a check to ensure the two code blocks have different languages before creating a switchable code tab. Refs: nodejs/node#62181 Co-authored-by: Copilot <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Fixes an issue in the legacy Shiki rehype transformer where consecutive code blocks could be incorrectly grouped into a CJS/MJS toggle even when both blocks use the same language.
Changes:
- Add a language inequality check before creating a switchable CJS/MJS code tab.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ovflowd
added
the
github_actions
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 75.89% 75.88% -0.02%
==========================================
Files 145 145
Lines 13728 13722 -6
Branches 992 991 -1
==========================================
- Hits 10419 10413 -6
Misses 3303 3303
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
avivkeller
removed
the
github_actions
ovflowd
added
the
github_actions
avivkeller
removed
the
github_actions
|
@ovflowd the GitHub actions label doesn't trigger any actions, it's used by Dependabot |
|
Oh lol, used with nodejs.org repo xD |
Two consecutive code blocks with the same language (e.g., both
mjs) were incorrectly grouped into a CJS/MJS switchable tab. This adds a check to ensure the two code blocks have different languages before creating a switchable code tab.Refs: nodejs/node#62181