-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add WebAssembly
to primordials
#36433
Conversation
623895e
to
f016a82
Compare
Failures in GitHub CI (e.g., test-esm-wasm) seem related? |
I have no idea why: const { WebAssemblyCompile } = primordials;
WebAssemblyCompile(...); doesn’t work, but: const { WebAssembly } = primordials;
WebAssembly.compile(...); does. |
FWIW, it |
@ExE-Boss would you like to rebase? Maybe it will work with the current V8 version |
Co-authored-by: Antoine du Hamel <[email protected]>
f016a82
to
5788f16
Compare
IIUC this is never going to work because of the node/deps/v8/src/flags/flag-definitions.h Line 1533 in 38ef4e5
|
This is used to handle support for WebAssembly modules and static analysis of named exports from CommonJS modules.
Note that adding WebAssembly types to
/typings/primordials.d.ts
depends on microsoft/TypeScript-DOM-lib-generator#959 in order to avoid addinglib: ["DOM"]
totsconfig.json
.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes