-
-
Notifications
You must be signed in to change notification settings - Fork 32k
lib: avoid repl.setupHistory() blocks node exit after repl closed #52587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@lucshi Can you add tests for the change? |
Sure I will add a test. Thanks! |
@cola119 Could you please take a look? Thank! |
Can you fix the linter errors? |
Sure, just noticed the errors. Done. |
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/8824871644 |
@node/lib |
Hi @cola119, Could you please take a look at this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK an alternative should be to only write sync. That would also make sure things are written properly and it is closed.
This PR will need to be rebased. The CI detects this PR as being Node.js 22 because it was opened last year and is picking the compiler for that version of Node.js instead of the compiler that should be used for |
Fixes: #52386