doc: mark more long-time experimental APIs as stable #57513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jasnell wants to merge 9 commits into nodejs:main from jasnell:jasnell/mark-moar-apis-stable

Member

jasnell commented Mar 17, 2025

I'm guessing 3-7 years is long enough to be experimental

nodejs-github-bot added the doc label

jasnell commented

View reviewed changes

doc/api/buffer.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/readline.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

jasnell added 5 commits

March 20, 2025 12:47


          doc: mark object url APIs stable

4d035fb


          doc: mark more streams apis stable

e3d712d


          doc: mark readline promises api stable

188edf7


          doc: mark multiple fs APIs as stable

785d37e


          fixup! doc: mark multiple fs APIs as stable

2f7f7ba

jasnell force-pushed the jasnell/mark-moar-apis-stable branch from ec614a5 to 2f7f7ba Compare

March 20, 2025 19:57

jasnell requested review from benjamingr, mhdawson, legendecas, marco-ippolito, aduh95, anonrig and trivikr

March 20, 2025 19:58

Member Author

jasnell commented Mar 20, 2025

Reverted the stream iterator helpers and the vm module changes.

jasnell dismissed benjamingr’s stale review

March 20, 2025 20:54

Resolved

aduh95 reviewed

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved

aduh95 reviewed

View reviewed changes

doc/api/stream.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

19c2bb5

Co-authored-by: Antoine du Hamel <[email protected]>

jasnell requested a review from aduh95

March 20, 2025 22:08

aduh95 approved these changes

View reviewed changes

legendecas approved these changes

View reviewed changes

jasnell added a commit that referenced this pull request


          doc: mark multiple vm module APIS stable

4006d5e

I'm guessing 5-7 years is long enough to be experimental

* mark worker_threads API stable
* mark multiple v8 module APIs stable
* mark object url APIs stable
* mark more streams apis stable
* mark readline promises api stable
* mark multiple fs APIs as stable

PR-URL: #57513
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

Member Author

jasnell commented Mar 21, 2025

Landed in 4006d5e

jasnell closed this

Member

legendecas commented Mar 21, 2025

@jasnell the commit message 4006d5e seems outdated though. It says marking "vm modules APIs", but it did not.

Member Author

jasnell commented Mar 21, 2025

Doh. Ok, not much we can do now but yeah, I overlooked that when landing

aduh95 added the dont-land-on-v23.x label

RafaelGSS pushed a commit that referenced this pull request


          doc: mark multiple vm module APIS stable

fc7ce54

I'm guessing 5-7 years is long enough to be experimental

* mark worker_threads API stable
* mark multiple v8 module APIs stable
* mark object url APIs stable
* mark more streams apis stable
* mark readline promises api stable
* mark multiple fs APIs as stable

PR-URL: #57513
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

RafaelGSS pushed a commit that referenced this pull request


          doc: mark multiple vm module APIS stable

8e96988

I'm guessing 5-7 years is long enough to be experimental

* mark worker_threads API stable
* mark multiple v8 module APIs stable
* mark object url APIs stable
* mark more streams apis stable
* mark readline promises api stable
* mark multiple fs APIs as stable

PR-URL: #57513
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas legendecas approved these changes

aduh95 aduh95 approved these changes

benjamingr Awaiting requested review from benjamingr

mhdawson Awaiting requested review from mhdawson

marco-ippolito Awaiting requested review from marco-ippolito

anonrig Awaiting requested review from anonrig

trivikr Awaiting requested review from trivikr

Labels

doc dont-land-on-v23.x