Skip to content

inspector: add protocol method Network.dataReceived #58001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Apr 24, 2025

Add inspector.Network.dataReceived API to allow DevTools to monitor received http data chunks.

Refs: #53946
Refs: nodejs/undici#4166

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 24, 2025
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 60.36036% with 44 lines in your changes missing coverage. Please review.

Project coverage is 90.26%. Comparing base (555aeb3) to head (3fc383a).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector/node_string.cc 59.18% 18 Missing and 2 partials ⚠️
src/inspector/network_agent.cc 62.74% 9 Missing and 10 partials ⚠️
src/inspector/node_string.h 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58001      +/-   ##
==========================================
- Coverage   90.27%   90.26%   -0.02%     
==========================================
  Files         630      630              
  Lines      186168   186268     +100     
  Branches    36477    36496      +19     
==========================================
+ Hits       168069   168136      +67     
- Misses      10974    11004      +30     
- Partials     7125     7128       +3     
Files with missing lines Coverage Δ
lib/inspector.js 96.92% <100.00%> (+0.01%) ⬆️
src/inspector/node_string.h 64.28% <50.00%> (+7.14%) ⬆️
src/inspector/network_agent.cc 61.88% <62.74%> (+0.22%) ⬆️
src/inspector/node_string.cc 59.59% <59.18%> (-0.41%) ⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas force-pushed the inspector/data-received-src branch from bda9a11 to 1d3f636 Compare April 24, 2025 12:28
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Apr 24, 2025
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@nodejs-github-bot

This comment was marked as outdated.

@legendecas legendecas force-pushed the inspector/data-received-src branch from 1d3f636 to 3fc383a Compare April 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants