esm: graduate import.meta properties #58011
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark as no longer experimental: * `import.meta.resolve()` * `import.meta.dirname` * `import.meta.filename`
|
Review requested:
|
nodejs-github-bot
added
doc
jasnell
added
the
semver-minor
anonrig
approved these changes
Apr 24, 2025
marco-ippolito
approved these changes
Apr 24, 2025
guybedford
approved these changes
Apr 25, 2025
jasnell
added
the
author ready
aduh95
reviewed
Apr 25, 2025
| @@ -350,10 +350,12 @@ properties. It is only supported in ES modules. | |||
| added: | |||
| - v21.2.0 | |||
| - v20.11.0 | |||
| changes: | |||
| - version: REPLACEME | |||
| pr-url: https://github.com/nodejs/node/pull/00000 | |||
There was a problem hiding this comment.
Suggested change
| pr-url: https://github.com/nodejs/node/pull/00000 | |
| pr-url: https://github.com/nodejs/node/pull/58011 |
aduh95
reviewed
Apr 25, 2025
Comment on lines
+405
to
+407
| - version: REPLACEME | ||
| pr-url: https://github.com/nodejs/node/pull/00000 | ||
| description: This property is no longer experimental. |
There was a problem hiding this comment.
IMO we should first make --experimental-import-meta-resolve a no-op and expose an API to replace it. I have a PR for that, I just need to get back to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark as no longer experimental:
import.meta.resolve()import.meta.dirnameimport.meta.filename