Skip to content

test: add ALS test using http agent keep alive #58017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Apr 25, 2025

Add a test to verify AsyncLocalStore functionality for HTTP using a keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on async_hooks tests alone is not longer valid.

Refs: #55712
Refs: #13325

@Flarna Flarna added the async_local_storage AsyncLocalStorage label Apr 25, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 25, 2025
@Flarna Flarna force-pushed the als-http-tests branch 2 times, most recently from 370b595 to 9b3271b Compare April 25, 2025 07:08
@lpinca
Copy link
Member

lpinca commented Apr 25, 2025

"Add a tests" -> "Add a test" in commit message.

Add a test to verify AsyncLocalStore functionality for HTTP using a
keep alive agent.

AsyncLocalStore moves away from using async_hooks therefore relying on
async_hooks tests alone is not longer valid.
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (b665127) to head (887ae7a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58017   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files         630      630           
  Lines      186158   186158           
  Branches    36475    36472    -3     
=======================================
+ Hits       168047   168049    +2     
+ Misses      10980    10979    -1     
+ Partials     7131     7130    -1     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Flarna Flarna added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66448/

@Flarna Flarna added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2025
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_local_storage AsyncLocalStorage author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants