test: deflake test-config-file

[lpinca]

test: deflake test-config-file

Port 9229 may already be used by another process. Use a random
available one.

test: save the config file in a temporary directory

Allow the test to be run in parallel.

Refs: #58799 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/config

[lpinca]

This fixes

not ok 228 parallel/test-config-file
  ---
  duration_ms: 4215.14300
  severity: fail
  exitcode: 1
  stack: |-
    Test failure: '--inspect=true should be parsed correctly'
    Location: test\parallel\test-config-file.js:237:1
    AssertionError [ERR_ASSERTION]: The input did not match the regular expression /^Debugger listening on (ws:\/\/[^\s]+)/. Input:
    
    'Starting inspector on 127.0.0.1:9229 failed: address already in use\r\n'
    
        at TestContext.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-config-file.js:244:3)
        at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
        at async Test.run (node:internal/test_runner/test:1054:7)
        at async Test.processPendingSubtests (node:internal/test_runner/test:744:7) {
      generatedMessage: true,
      code: 'ERR_ASSERTION',
      actual: 'Starting inspector on 127.0.0.1:9229 failed: address already in use\r\n',
      expected: /^Debugger listening on (ws:\/\/[^\s]+)/,
 ...

[lpinca]

I also think that this test

node/test/parallel/test-config-file.js

Lines 363 to 381 in af66574

	// Skip on windows because it doesn't support chmod changing read permissions
	// Also skip if user is root because it would have read permissions anyway
	test('should throw an error when the file is non readable', {
	skip: common.isWindows || process.getuid() === 0,
	}, async () => {
	chmodSync(fixtures.path('rc/non-readable/node.config.json'), constants.O_RDONLY);
	const result = await spawnPromisified(process.execPath, [
	'--no-warnings',
	'--experimental-default-config-file',
	'-p', 'http.maxHeaderSize',
	], {
	cwd: fixtures.path('rc/non-readable'),
	});
	match(result.stderr, /Cannot read configuration from node\.config\.json: permission denied/);
	strictEqual(result.stdout, '');
	strictEqual(result.code, 9);
	chmodSync(fixtures.path('rc/non-readable/node.config.json'),
	constants.S_IRWXU | constants.S_IRWXG | constants.S_IRWXO);
	});

Should be moved to sequential or use a temporary directory as it cannot be run in parallel (./tools/tests.py --repeat 1000).

[lpinca]

PTAL, I've added a new a commit to address my previous comment.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67616/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (910a8af) to head (8bfd35b).
Report is 23 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58799      +/-   ##
==========================================
+ Coverage   90.07%   90.08%   +0.01%     
==========================================
  Files         640      640              
  Lines      188287   188262      -25     
  Branches    36909    36912       +3     
==========================================
- Hits       169599   169598       -1     
+ Misses      11410    11397      -13     
+ Partials     7278     7267      -11     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67617/

[nodejs-github-bot]

Landed in ac540c0...100c6da