Skip to content

[v24.x] deps: V8: backport 1c3e018e7d48 #58818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v24.x-staging
Choose a base branch
from
Open

[v24.x] deps: V8: backport 1c3e018e7d48 #58818

wants to merge 1 commit into from

Conversation

Renegade334
Copy link
Contributor

This backport from 13.7 facilitates defining ERM disposal methods within the C++ layer.

Original commit message:

Expose dispose and asyncDispose symbols to C++

Since `Symbol.dispose` has been exposed to JS we need to be able to
access the native v8::Symbol too.

Change-Id: I9111d2806630efdd8bb5f931effa9adad3c85ae5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6410112
Commit-Queue: Erik Corry <[email protected]>
Reviewed-by: Erik Corry <[email protected]>
Reviewed-by: Leszek Swirski <[email protected]>
Cr-Commit-Position: refs/heads/main@{#99590}

refs: v8/v8@1c3e018

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Jun 24, 2025
@Renegade334 Renegade334 marked this pull request as ready for review June 24, 2025 19:14
@RafaelGSS
Copy link
Member

Is there any reason not to have it on main as well?

@Renegade334
Copy link
Contributor Author

It already is, via #58064.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Renegade334 @nodejs-github-bot @RafaelGSS