Conversation
|
Review requested:
|
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 404 Not Foundhttps://github.com/nodejs/node/actions/runs/22032932485 |
|
There seems to be a related failure on Windows: |
|
I've taken a look at this. First of all, both native and JS tests (some other than the one mentioned in a previous comment) failed, so I reran the 2 jobs (native, JS), and the only failure left is the one from The reason for the failure seems to be the change from this PR. I do not know how the others feel, but for me personally, changing the expected behavior to a new error doesn't seem like a big issue and I'd go with that approach. Of course, I leave the option that there is something that would not allow this that I'm not aware of, so if there is, please let me know. |
6a25a76 to
5915071
Compare
5915071 to
d240140
Compare
|
Hey all, just wanted to ping here again about the Windows test failure and my suggestion to fix it - changing the error we expect in the test. If there are some objections to that approach, please let me know. Otherwise, I'll push the change to the test on Thursday/Friday this week. |
d240140 to
d282cbb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61829 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 676 676
Lines 206543 206546 +3
Branches 39547 39541 -6
=======================================
+ Hits 185184 185188 +4
- Misses 13480 13493 +13
+ Partials 7879 7865 -14 🚀 New features to boost your workflow:
|
|
@StefanStojanovic looks like your change breaks every other platforms though |
Well, at least now it's no longer my problem, Windows works well... xD Just kidding, will put a |
10def3e to
3622960
Compare
|
If the behaviour is different on windows now and inconsistent with other platforms then maybe it is an actual bug in libuv? |
|
Marking as requested for v24.x via #62232 |
|
(lands cleanly!) |
3622960 to
b6996a1
Compare
Commit Queue failed- Loading data for nodejs/node/pull/61829 ✔ Done loading data for nodejs/node/pull/61829 ----------------------------------- PR info ------------------------------------ Title deps: update libuv to 1.52.1 (#61829) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-libuv -> nodejs:main Labels libuv, author ready, needs-ci, dependencies, lts-watch-v24.x Commits 1 - deps: update libuv to 1.52.1 Committers 1 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/61829 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61829 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - deps: update libuv to 1.52.1 ℹ This PR was created on Sun, 15 Feb 2026 00:52:06 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61829#pullrequestreview-3803977138 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805075669 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805249263 ✔ - Santiago Gimeno (@santigimeno): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805558272 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61829#pullrequestreview-3915039213 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/61829#pullrequestreview-3949140194 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2026-03-14T18:52:12Z: https://ci.nodejs.org/job/node-test-pull-request/71766/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - deps: update libuv to 1.52.1 - Querying data for job/node-test-pull-request/71766/ ✔ Build data downloaded - Querying failures of job/node-test-commit/85981/ ✔ Data downloaded ✘ 7 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/23101775390 |
b6996a1 to
3622960
Compare
This is an automated update of libuv to 1.52.1.