Skip to content

lib: fixes validator message#62823

Open
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:fixes-validator
Open

lib: fixes validator message#62823
watilde wants to merge 1 commit intonodejs:mainfrom
watilde:fixes-validator

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Apr 19, 2026

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.61%. Comparing base (d44a71a) to head (5845946).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62823      +/-   ##
==========================================
- Coverage   89.61%   89.61%   -0.01%     
==========================================
  Files         706      706              
  Lines      219203   219203              
  Branches    41995    41998       +3     
==========================================
- Hits       196445   196429      -16     
- Misses      14663    14683      +20     
+ Partials     8095     8091       -4     
Files with missing lines Coverage Δ
lib/internal/validators.js 98.25% <100.00%> (ø)

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watilde watilde added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Apr 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@watilde watilde added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 23, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/62823
✔  Done loading data for nodejs/node/pull/62823
----------------------------------- PR info ------------------------------------
Title      lib: fixes validator message (#62823)
Author     Daijiro Wachi <[email protected]> (@watilde)
Branch     watilde:fixes-validator -> nodejs:main
Labels     author ready
Commits    1
 - lib: fixes validator message
Committers 1
 - Daijiro Wachi <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/62823
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62823
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 19 Apr 2026 09:03:15 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62823#pullrequestreview-4142889448
   ✘  This PR needs to wait 79 more hours to land (or 0 minutes if there is one more approval)
   ✘  GitHub CI failed with status: FAILURE
   ℹ  Last Full PR CI on 2026-04-22T13:06:59Z: https://ci.nodejs.org/job/node-test-pull-request/72861/
- Querying data for job/node-test-pull-request/72861/
✔  Build data downloaded
- Querying failures of job/node-test-commit/87222/
✔  Data downloaded
   ✘  1 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/24813848187

@watilde watilde added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@watilde
Copy link
Copy Markdown
Member Author

watilde commented Apr 23, 2026

rebase and make the commit Verified.

@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants