Skip to content

crypto: reject inherited key type names #62875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Apr 23, 2026
+15 −0
Merged

crypto: reject inherited key type names #62875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4776784
crypto: reject inherited key type names
JonathanLopes404 Apr 21, 2026
3351caa
crypto: add __proto__ null to nidOnlyKeyPairs
JonathanLopes404 Apr 21, 2026
1704281
crypto: fix lint errors
JonathanLopes404 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/internal/crypto/keygen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const {
FunctionPrototypeCall,
ObjectDefineProperty,
ObjectPrototypeHasOwnProperty,
SafeArrayIterator,
} = primordials;

Expand Down Expand Up @@ -356,7 +357,7 @@ function createJob(mode, type, options) {
...encoding);
}
default: {
if (nidOnlyKeyPairs[type] === undefined) {
if (!ObjectPrototypeHasOwnProperty(nidOnlyKeyPairs, type)) {
throw new ERR_INVALID_ARG_VALUE('type', type, 'must be a supported key type');
}
return new NidKeyPairGenJob(mode, nidOnlyKeyPairs[type], ...encoding);
Expand Down
14 changes: 14 additions & 0 deletions test/parallel/test-crypto-keygen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ const { hasOpenSSL3 } = require('../common/crypto');
code: 'ERR_INVALID_ARG_VALUE',
message: "The argument 'type' must be a supported key type. Received 'rsa2'"
});

for (const type of ['toString', 'constructor']) {
assert.throws(() => generateKeyPairSync(type, {}), {
name: 'TypeError',
code: 'ERR_INVALID_ARG_VALUE',
message: `The argument 'type' must be a supported key type. Received '${type}'`
});

assert.throws(() => generateKeyPair(type, {}, common.mustNotCall()), {
name: 'TypeError',
code: 'ERR_INVALID_ARG_VALUE',
message: `The argument 'type' must be a supported key type. Received '${type}'`
});
}
}

{
Expand Down
Loading