build: track PDL files as inputs in inspector GN build#62888
Open
deepak1556 wants to merge 1 commit intonodejs:mainfrom
Open
build: track PDL files as inputs in inspector GN build#62888deepak1556 wants to merge 1 commit intonodejs:mainfrom
deepak1556 wants to merge 1 commit intonodejs:mainfrom
Conversation
The node_protocol_generated_sources action was missing gypi_values.node_pdl_files from its inputs, causing Ninja to skip regeneration when PDL domain files changed.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
approved these changes
Apr 22, 2026
addaleax
added
author ready
addaleax
approved these changes
Apr 24, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
node_protocol_generated_sourcesaction was missinggypi_values.node_pdl_filesfrom its inputs, causing Ninja to skip regeneration when PDL domain files changed.Refs electron/electron#51239