Skip to content

tools: reuse V8 builds even without Cachix on test-shared#62980

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:better-cache-v8
Apr 29, 2026
Merged

tools: reuse V8 builds even without Cachix on test-shared#62980
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:better-cache-v8

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 26, 2026

Follow up to #62862, this should help avoiding building same V8 version several times – because PRs do not have write access to Cachix, we need to fallback to using action artifacts, test run can be found in https://github.com/aduh95/node/actions/runs/24967350421.

@aduh95 aduh95 requested a review from panva April 26, 2026 22:49
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 26, 2026
Copy link
Copy Markdown
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 requested a review from cjihrig April 29, 2026 14:08
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 29, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2026
@nodejs-github-bot nodejs-github-bot merged commit af8eba2 into nodejs:main Apr 29, 2026
42 of 43 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in af8eba2

@aduh95 aduh95 deleted the better-cache-v8 branch April 29, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants