net: preserve port 80 in SocketAddress.parse#63058
Closed
cookesan wants to merge 1 commit intonodejs:mainfrom
Closed
net: preserve port 80 in SocketAddress.parse#63058cookesan wants to merge 1 commit intonodejs:mainfrom
cookesan wants to merge 1 commit intonodejs:mainfrom
Conversation
Fixes: nodejs#62906 Signed-off-by: Terry Chen <[email protected]>
6f34fb4 to
81e1f54
Compare
Contributor
Author
|
Closing this in favor of #62912, which is the earlier PR for the same issue. I missed it when opening this one and left a technical note there about an edge case in the raw port parsing approach. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63058 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.01%
==========================================
Files 708 708
Lines 220413 220423 +10
Branches 42275 42276 +1
==========================================
- Hits 197607 197600 -7
- Misses 14658 14659 +1
- Partials 8148 8164 +16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net.SocketAddressstringsFixes: #62906
Testing
make JOBS=8./node --test test/parallel/test-socketaddress.jspython3 tools/test.py parallel/test-socketaddressmake lint-jsgit diff --check