-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Change language picker icon #4503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e as suggested by nodejs#4441. Also fixes when the footer would have no margin in dark mode.
- Changed body background from hex code to variable. - Only remove footer on small screens.
Where did the icon come from originally? |
It came from http://www.languageicon.org/, see #3503. |
@nodejs/website |
It shouldn't be a PNG. |
It shouldn't be a PNG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use SVG files after optimizing it and no redundant attributes.
I have changed the icons to an svg by converting it from |
Since dark mode transition time is used in multiple places, I added a variable so if it needs to be changed it can be changed easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is this PR good for merging @XhmikosR ? |
Sorry, I can't review the result (this is one of the cases PR previews would go a long way). If someone can confirm everything looks good on both themes, that's good enough from my side judging by the code changes. |
@XhmikosR If you're online right now, here's a preview I'll keep around for the next 30 minutes or so: https://8080-arkinsolomon-nodejsorg-yges5368tg1.ws-us38.gitpod.io/ |
Thanks @Trott! Confirmed LGTM. The same optimizations could be made to the dark switcher icons later (inline them, optimize them, toggle the |
Fixes #3372. I know this had 2 pull requests created already, with the most recent one dying pretty quickly. It was a pretty simple change to use the new image. I did slightly modify the icon to be white only. It works fine for both light and dark modes.