Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated]: crowdin sync #7543

Closed
wants to merge 1 commit into from
Closed

[automated]: crowdin sync #7543

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 8, 2025

New Crowdin translations from the Node.js Crowdin project

@github-actions github-actions bot requested a review from a team as a code owner March 8, 2025 20:38
Copy link

vercel bot commented Mar 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 21, 2025 5:09am

Copy link

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

avivkeller
avivkeller previously approved these changes Mar 19, 2025
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @bmuenzenmeyer has concerns that must be addressed.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! The indentation is right

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Mar 21, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 21, 2025
Copy link
Contributor Author

github-actions bot commented Mar 21, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

@bmuenzenmeyer
Copy link
Collaborator

LGMT ! The indentation is right

https://github.com/nodejs/nodejs.org/pull/7543/files#diff-6013e2ddd5d11d27aeb3f28de0f619b008d759417d55387f3ae2425b9ac58164

image

going to try locally again. last i checked it was erroring

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to merge this and see how subsequent work shakes out - it still makes me a little worried things are not right.

image

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read the WHOLE thing - merging this - it's been something like 6 weeks of a backlog

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Mar 21, 2025
@bmuenzenmeyer bmuenzenmeyer linked an issue Mar 21, 2025 that may be closed by this pull request
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2025
@avivkeller avivkeller added this pull request to the merge queue Mar 21, 2025
@bmuenzenmeyer
Copy link
Collaborator

it failed, let's slow down

@avivkeller avivkeller removed this pull request from the merge queue due to a manual request Mar 21, 2025
@avivkeller
Copy link
Member

it failed, let's slow down

Ack! My bad. Aborted.

@bmuenzenmeyer
Copy link
Collaborator

prettier errors, i cant even.

@bmuenzenmeyer
Copy link
Collaborator

there's been behavior i've observed where the prettier formatting does not occur on force pushes - so if the PR is open for over a week. why it didnt run in the first case is unknown to me, i've looked and could not figure it out

@bmuenzenmeyer
Copy link
Collaborator

ran prettier , site broken
image

i knew i wasnt going crazy. we need to diagnose why this is occurring. its been very rough, slow going.

problems:

  • format does not always seem to run post-download from crowding
  • formatting the code we do get results in broken locales

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit block

@bmuenzenmeyer
Copy link
Collaborator

so prettier, when ran, adds another backtick to the homepage tabbed codebox. i cannot even revert it, because on save it re-formats. i can turn that off of course, but some part of our syntax makes it think it should be there.

image

again, indentation seems problematic

<div>
```js displayName="Create an HTTP Server"
    // server.mjs
    import { createServer } from 'node:http';

    const server = createServer((req, res) => {
      res.writeHead(200, { 'Content-Type': 'text/plain' });
      res.end('Hello World!\n');
    });

    // starts a simple http server locally on port 3000
    server.listen(3000, '127.0.0.1', () => {
      console.log('Listening on 127.0.0.1:3000');
    });

    // run with `node server.mjs`
    ```

```js displayName="Write Tests"
    // tests.mjs
    import assert from 'node:assert';
    import test from 'node:test';

    test('that 1 is equal 1', () => {
      assert.strictEqual(1, 1);
    });

    test('that throws as 1 is not equal 2', () => {
      // throws an exception because 1 != 2
      assert.strictEqual(1, 2);
    });

    // run with `node tests.mjs`
    ```

```js displayName="Read and Hash a File"
    // crypto.mjs
    import { createHash } from 'node:crypto';
    import { readFile } from 'node:fs/promises';

    const hasher = createHash('sha1');

    hasher.setEncoding('hex');
    // ensure you have a `package.json` file for this test!
    hasher.write(await readFile('package.json'));
    hasher.end();

    const fileHash = hasher.read();

    // run with `node crypto.mjs`
    ```

```js displayName="Streams Pipeline"
    // streams.mjs
    import { pipeline } from 'node:stream/promises';
    import { createReadStream, createWriteStream } from 'node:fs';
    import { createGzip } from 'node:zlib';

    // ensure you have a `package.json` file for this test!
    await pipeline
    (
      createReadStream('package.json'),
      createGzip(),
      createWriteStream('package.json.gz')
    );

    // run with `node streams.mjs`
    ```

```js displayName="Work with Threads"
    // threads.mjs
    import { Worker, isMainThread,
      workerData, parentPort } from 'node:worker_threads';

    if (isMainThread) {
      const data = 'some data';
      const worker = new Worker(import.meta.filename, { workerData: data });
      worker.on('message', msg => console.log('Reply from Thread:', msg));
    } else {
      const source = workerData;
      parentPort.postMessage(btoa(source.toUpperCase()));
    }

    // run with `node threads.mjs`
    ```
</div>

@avivkeller avivkeller dismissed their stale review March 21, 2025 19:51

This PR is not in the state where I would approve.

@bmuenzenmeyer
Copy link
Collaborator

what i know

correct in en locale

image

in crowdin's editor, it looks wrong (indentation lost). this is even before download. so could something in upload be messing it up?

image

going to ask this to crowdin. previous attempts have always been in Slack with more documentation of the problem.

@bmuenzenmeyer
Copy link
Collaborator

closing and trying again per Andriy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

h1 header is not syncing correctly on some non-English pages
5 participants