-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automated]: crowdin sync #7543
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0aa0a57
to
7c7d246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @bmuenzenmeyer has concerns that must be addressed.
7c7d246
to
b9ef746
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! The indentation is right
Lighthouse Results
|
going to try locally again. last i checked it was erroring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read the WHOLE thing - merging this - it's been something like 6 weeks of a backlog
it failed, let's slow down |
Ack! My bad. Aborted. |
prettier errors, i cant even. |
there's been behavior i've observed where the prettier formatting does not occur on force pushes - so if the PR is open for over a week. why it didnt run in the first case is unknown to me, i've looked and could not figure it out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit block
so prettier, when ran, adds another backtick to the homepage tabbed codebox. i cannot even revert it, because on save it re-formats. i can turn that off of course, but some part of our syntax makes it think it should be there. again, indentation seems problematic
|
This PR is not in the state where I would approve.
what i know in crowdin's editor, it looks wrong (indentation lost). this is even before download. so could something in upload be messing it up? going to ask this to crowdin. previous attempts have always been in Slack with more documentation of the problem. |
closing and trying again per Andriy |
New Crowdin translations from the Node.js Crowdin project