-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: r2 migration blog post #7545
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
Lighthouse Results
|
We won't be able to support Mermaid rendering soon, unfortunately. The package mermaid-isomorphic does some funky things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flakey5 I think we can proceed with this as it is. Mermaid support will probably take a long while.
Signed-off-by: flakey5 <[email protected]>
5df7652
to
6592916
Compare
Signed-off-by: flakey5 <[email protected]>
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
cc @nodejs/build |
Signed-off-by: flakey5 <[email protected]>
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/blog/announcements/making-nodejs-downloads-reliable.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Aviv Keller <[email protected]> Co-authored-by: Antoine du Hamel <[email protected]> Signed-off-by: flakey5 <[email protected]>
@flakey5 we're good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
Signed-off-by: flakey5 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we could have a SVG version instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry missed this 🤦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? Fwiw the precedent has been just images, but either work
Blog post for announcing the R2 migration!
Ideally this can be merged after #7544 so we can use it in the diagrams instead of adding more images.