-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta: npm audit fix
lockfile
#7565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
https://github.com/nodejs/nodejs.org/actions/runs/14017847496/job/39245822446 says that Dependabot thinks "The lockfile might be out of sync?" |
@AugustinMauroy looks like an ESlint related error occurred. Did you update the entire lock file or just Babel? |
I just do an
maybe come form monorepo ? |
Looking at the lock file, it looks like the audit updated all the dependencies. So if we just fix the ESLint error, this should be fine. |
Strange behavior of npm. I pretty sure that I didn't ran |
fix error + update pr description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we should wait a day or two for more reviews just to be sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This has enough approvals to land, but I ask that you want until #7401 lands to avoid conflicts (like 8 hours, sorry for the delay). It'd be easier to simply run this command after that PR than to rebase and manually setup and trigger a retest in that PR, especially because this changes a lot of dependencies. I don't want to risk breaking anything. If you'd rather land this first, that's okay too! I'll rebase and retest that PR, it won't take too much work. |
7c89dcc
to
e7596bd
Compare
Description
For strange reason dependabot can't fix security update on our dep so I do it manually.
When I update lockfile it's had also update eslint in sub-dep so I had to fix error
Validation
CI should pass
Related Issues
https://github.com/nodejs/nodejs.org/security/dependabot/68
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.