Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: npm audit fix lockfile #7565

Merged
merged 2 commits into from
Mar 25, 2025
Merged

meta: npm audit fix lockfile #7565

merged 2 commits into from
Mar 25, 2025

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Mar 23, 2025

Description

For strange reason dependabot can't fix security update on our dep so I do it manually.
When I update lockfile it's had also update eslint in sub-dep so I had to fix error

Validation

CI should pass

Related Issues

https://github.com/nodejs/nodejs.org/security/dependabot/68

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Sorry, something went wrong.

@Copilot Copilot bot review requested due to automatic review settings March 23, 2025 09:14
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner March 23, 2025 09:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

vercel bot commented Mar 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 25, 2025 10:19am

Copy link
Contributor

github-actions bot commented Mar 23, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 86 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller
Copy link
Member

For strange reason dependabot can't fix security update on our dep so I do it manually.

https://github.com/nodejs/nodejs.org/actions/runs/14017847496/job/39245822446 says that Dependabot thinks "The lockfile might be out of sync?"

Copy link
Contributor

github-actions bot commented Mar 23, 2025

Unit Test Coverage Report

Title Lines Statements Branches Functions
@node-core/ui-components Coverage: 95%
95.83% (161/168) 77.86% (102/131) 88.57% (31/35)
@nodejs/website Coverage: 87%
84.74% (500/590) 76.03% (165/217) 87.09% (108/124)
Title Tests Skipped Failures Errors Time
@node-core/ui-components 24 0 💤 0 ❌ 0 🔥 5.142s ⏱️
@nodejs/website 157 0 💤 0 ❌ 0 🔥 6.713s ⏱️

@avivkeller
Copy link
Member

@AugustinMauroy looks like an ESlint related error occurred. Did you update the entire lock file or just Babel?

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Mar 23, 2025

Did you update the entire lock file or just Babel?

I just do an npm audit fix. but eslint output look legit. So why it's not failing on main ??

https://github.com/nodejs/nodejs.org/actions/runs/14017847496/job/39245822446 says that Dependabot thinks "The lockfile might be out of sync?"

maybe come form monorepo ?

@avivkeller
Copy link
Member

avivkeller commented Mar 23, 2025

I just do an npm audit fix. but eslint output look legit. So why it's not failing on main ??

Looking at the lock file, it looks like the audit updated all the dependencies.

So if we just fix the ESLint error, this should be fine.

@avivkeller avivkeller changed the title meta: update security dep meta: npm audit fix lockfile Mar 23, 2025
@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Mar 23, 2025

Looking at the lock file, it looks like the audit updated all the dependencies.

Strange behavior of npm. I pretty sure that I didn't ran npm update

@AugustinMauroy
Copy link
Member Author

fix error + update pr description

Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should wait a day or two for more reviews just to be sure

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@avivkeller
Copy link
Member

avivkeller commented Mar 24, 2025

This has enough approvals to land, but I ask that you want until #7401 lands to avoid conflicts (like 8 hours, sorry for the delay). It'd be easier to simply run this command after that PR than to rebase and manually setup and trigger a retest in that PR, especially because this changes a lot of dependencies. I don't want to risk breaking anything.

If you'd rather land this first, that's okay too! I'll rebase and retest that PR, it won't take too much work.

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Mar 25, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 25, 2025
@AugustinMauroy AugustinMauroy added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit 7d6831b Mar 25, 2025
15 checks passed
@AugustinMauroy AugustinMauroy deleted the meta-bump branch March 25, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants