Skip to content

Conversation

@micheleriva
Copy link
Contributor

This PR supersedes #7971 and integrates the new Orama components, powered by the new OramaCore backend.

Description

New components - React-based to replace the old WebComponents-based ones. New backend (OramaCore instead of old Orama Cloud), all hosted and maintained on https://app.orama.com. Credentials have been shared privately with the repository maintainers on Slack.

Validation

Tested locally and on remote demo environment.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

g-francesca and others added 30 commits July 9, 2025 11:54
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]>
Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
@avivkeller
Copy link
Member

Can you update main/.github/workflows/sync-orama.yml to use the new API keys?
See nodejs/nodejs.org/actions/runs/18316807448/job/52159169199?pr=8175

@avivkeller I updated the workflow. Can you please confirm that you also set this env vars on github/vercel?

NEW_ORAMA_PROJECT_ID
NEW_ORAMA_PRIVATE_API_KEY
NEW_ORAMA_DATASOURCE_ID

Thanks!

Screenshot 2025-10-10 at 13 38 01

@avivkeller
Copy link
Member

avivkeller commented Oct 10, 2025

@nodejs/web-infra Can you copy the NEW_ORAMA_PROJECT_ID / NEW_PRODUCTION_ORAMA_PROJECT_ID from Vercel into GH Actions?

@avivkeller
Copy link
Member

Apologies for the delays here! I was at JSConf.

@g-francesca Can you please "Resolve" all the conversations that you believe have been resolved, and then re-request a review from @ovflowd?

@avivkeller
Copy link
Member

@nodejs/web-infra Can you copy the NEW_ORAMA_PROJECT_ID / NEW_PRODUCTION_ORAMA_PROJECT_ID from Vercel into GH Actions?

I've set these as 2eac5680-790b-44b7-8640-359608f104bd / 939d8d74-dbb7-4098-ac46-00325a783e17 respectively (per https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1756145667553889?thread_ts=1755714272.918999&cid=CVAMEJ4UV and https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1755908231889699?thread_ts=1755714272.918999&cid=CVAMEJ4UV, respectively)

@ovflowd
Copy link
Member

ovflowd commented Oct 19, 2025

@nodejs/web-infra Can you copy the NEW_ORAMA_PROJECT_ID / NEW_PRODUCTION_ORAMA_PROJECT_ID from Vercel into GH Actions?

@nodejs/web-infra has someone done this?

@avivkeller
Copy link
Member

@nodejs/web-infra has someone done this?

I did, see #8175 (comment)

@g-francesca
Copy link

Apologies for the delays here! I was at JSConf.

@g-francesca Can you please "Resolve" all the conversations that you believe have been resolved, and then re-request a review from @ovflowd?

@avivkeller @ovflowd I believe I don’t have permissions to mark the conversations as resolved, but I’ve added ✅ replies where changes were applied, and I'm re-requesting the review. TY!

@g-francesca
Copy link

Apologies for the delays here! I was at JSConf.
@g-francesca Can you please "Resolve" all the conversations that you believe have been resolved, and then re-request a review from @ovflowd?

@avivkeller @ovflowd I believe I don’t have permissions to mark the conversations as resolved, but I’ve added ✅ replies where changes were applied, and I'm re-requesting the review. TY!

I’ve just realized I don’t have permission to re-request a review either, but all feedback has been addressed. Feel free to proceed with the review when possible @ovflowd

@bmuenzenmeyer bmuenzenmeyer requested a review from ovflowd October 20, 2025 12:05
@ovflowd
Copy link
Member

ovflowd commented Oct 20, 2025

I see that Playwright tests are failing?

@avivkeller
Copy link
Member

@g-francesca Could you please:

  1. Resolve the Playwright issues
  2. Resolve any conflicts (Maybe merging your commits will help with that, 110 is quite a lot 😅)

@g-francesca
Copy link

@g-francesca Could you please:

  1. Resolve the Playwright issues
  2. Resolve any conflicts (Maybe merging your commits will help with that, 110 is quite a lot 😅)

🙂​ Sure, I'll manage this today @avivkeller.
About the Playwright tests:
I noticed they’re currently failing in CI because the Orama env vars (used to initialize the client) aren’t defined during the test step. Since we made the search button disabled whenever these variables are missing, the tests pass locally, but fail in GitHub Actions, as the button can’t be clicked.

Before I update the workflow to include them, could you confirm whether the variables below are already set as secrets? And if there's any distinction between those used in prod and preview environments that I should take into account?

Would the following update to the test step look correct to you?

      - name: Run Playwright tests
        working-directory: apps/site
        run: node --run playwright
        env:
          PLAYWRIGHT_BASE_URL: ${{ needs.get-vercel-preview.outputs.url }}
          NEXT_PUBLIC_NEW_ORAMA_PROJECT_ID: ${{ github.event_name == 'push' && secrets.NEXT_PUBLIC_NEW_ORAMA_PRODUCTION_PROJECT_ID || secrets.NEXT_PUBLIC_NEW_ORAMA_PROJECT_ID }}
          NEXT_PUBLIC_NEW_ORAMA_API_KEY: ${{ github.event_name == 'push' && secrets.NEXT_PUBLIC_NEW_ORAMA_PRODUCTION_API_KEY || secrets.NEXT_PUBLIC_NEW_ORAMA_API_KEY }}

Thank you!

@ovflowd
Copy link
Member

ovflowd commented Oct 23, 2025

@avivkeller would the GHA snippet above be OK?

@avivkeller
Copy link
Member

avivkeller commented Oct 23, 2025

(Forget my deleted comment above)

No, the snippet does not look good to me. Playwright should run without secrets. We could just remove the Orama tests, and accept that this is a third-party provider not subject to our tests.

@avivkeller
Copy link
Member

avivkeller commented Oct 23, 2025

The "Sync Orama Cloud" test is an expected failure given the changes, but can someone confirm that a local call of that script works with the secrets defined?

If not, I can make a temporary branch to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants