-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(search): use new Orama components #8175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Aileen Villanueva Lecuona <[email protected]>
|
|
@nodejs/web-infra Can you copy the |
|
Apologies for the delays here! I was at JSConf. @g-francesca Can you please "Resolve" all the conversations that you believe have been resolved, and then re-request a review from @ovflowd? |
I've set these as |
@nodejs/web-infra has someone done this? |
I did, see #8175 (comment) |
@avivkeller @ovflowd I believe I don’t have permissions to mark the conversations as resolved, but I’ve added ✅ replies where changes were applied, and I'm re-requesting the review. TY! |
I’ve just realized I don’t have permission to re-request a review either, but all feedback has been addressed. Feel free to proceed with the review when possible @ovflowd |
|
I see that Playwright tests are failing? |
|
@g-francesca Could you please:
|
🙂 Sure, I'll manage this today @avivkeller. Before I update the workflow to include them, could you confirm whether the variables below are already set as secrets? And if there's any distinction between those used in prod and preview environments that I should take into account? Would the following update to the test step look correct to you? Thank you! |
|
@avivkeller would the GHA snippet above be OK? |
|
(Forget my deleted comment above) No, the snippet does not look good to me. Playwright should run without secrets. We could just remove the Orama tests, and accept that this is a third-party provider not subject to our tests. |
|
The "Sync Orama Cloud" test is an expected failure given the changes, but can someone confirm that a local call of that script works with the secrets defined? If not, I can make a temporary branch to test it. |

This PR supersedes #7971 and integrates the new Orama components, powered by the new OramaCore backend.
Description
New components - React-based to replace the old WebComponents-based ones. New backend (OramaCore instead of old Orama Cloud), all hosted and maintained on https://app.orama.com. Credentials have been shared privately with the repository maintainers on Slack.
Validation
Tested locally and on remote demo environment.
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.