-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(release-blogs): fix a few issues #8259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes several issues in the release blog post generator workflow and script to properly handle version arguments and error reporting.
Key Changes:
- Updated argument parsing to use
parseArgsinstead of manualprocess.argvmanipulation - Added support for version strings in
vX.Y.Zformat by stripping the leading 'v' - Configured the workflow to pass
GITHUB_TOKENexplicitly and set the correct working directory
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/site/scripts/release-post/index.mjs | Replaced manual argument parsing with parseArgs API, added version format normalization, and removed error suppression |
| .github/workflows/create-release-post.yml | Added working directory configuration and explicit GITHUB_TOKEN passing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8259 +/- ##
=======================================
Coverage 76.57% 76.57%
=======================================
Files 117 117
Lines 9733 9733
Branches 329 329
=======================================
Hits 7453 7453
Misses 2278 2278
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Sorry that this ended up being two PRs! You can't test a Successful Run: https://github.com/nodejs/nodejs.org/actions/runs/18730461924 |
83024fb to
e06b92f
Compare
|
@avivkeller I wanted to share https://github.com/github/local-action - I recently discovered this and found it useful - it sorta depends on how a workflow is constructed, but it is more lightweight than https://github.com/nektos/act |
Fixes the following with the release blog post generator:
$VERSIONargumentGITHUB_TOKENexplicitly to this action (https://github.com/gr2m/create-or-update-pull-request-action/blob/master/index.js#L15), and it needs a bit more permissionsvX.Y.Zformat, and the script is currently only equipped to handleX.Y.ZformatSorry that this ended up being two PRs! You can't test a
workflow_dispatchtrigger before it's merged into themainbranch.Successful Run: https://github.com/nodejs/nodejs.org/actions/runs/18730461924
Example PR: #8260 (The content of this PR looks like it doesn't do anything, but it generated a release post identical to that of
main, hence why the file diff didn't incldue it)