fix: 301 and 302 change method to GET #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
approved these changes
Nov 21, 2024
ronag
requested changes
Nov 21, 2024
ronag
reviewed
Nov 21, 2024
ronag
reviewed
Nov 21, 2024
ronag
approved these changes
Nov 21, 2024
DTrombett
commented
Nov 21, 2024
|
semver major? |
ronag
approved these changes
Nov 21, 2024
|
IMHO a bug fix @mcollina |
metcoder95
approved these changes
Nov 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Didn't open an issue before this PR so sorry if this is expected but I could not find any discussion about it.
The redirect handler doesn't change the method to
GETwhen the status code is 301/302 and the original method isPOSTdespite being the standard in fetch spec and browser behavior. Also the HTTP standard mentions this too:Rationale
Changes
Method is changed to
GETand body is removed when a 301/302 response code is received, aligning with fetch and browser behaviorThe tests were updated to reflect this change and the ones specifically about request body/method were updated to use
PUTinsteadFeatures
Bug Fixes
Breaking Changes and Deprecations
Status