fix: handle missing vary header values #4031
Conversation
Co-authored-by: SukkaW <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (const key of Object.keys(opts.headers)) { | ||
| headers[key.toLowerCase()] = opts.headers[key] | ||
| } |
There was a problem hiding this comment.
If we don't do this, we lose case insensitivity in the cache unfortunately and the unit test fails
There was a problem hiding this comment.
why? I thought headers name were already lowercased elsewhere?
There was a problem hiding this comment.
The keys in the cache are lowercase but opts.headers keys are not
In the last request of the unit test we pass Accept-Encoding and it's value in the opts object is still Accept-Encoding, so the cache thinks the third request still doesn't have an accept-encoding property and uses the stored value
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, the response headers are already lowercased once parsed, but we do not handle the ones passed by the call to dispatch; those can be potentially upper cased
| for (const key of Object.keys(opts.headers)) { | ||
| headers[key.toLowerCase()] = opts.headers[key] | ||
| } |
There was a problem hiding this comment.
why? I thought headers name were already lowercased elsewhere?
Co-authored-by: Matteo Collina <[email protected]>
Co-authored-by: Matteo Collina <[email protected]>
| for (const key of Object.keys(opts.headers)) { | ||
| headers[key.toLowerCase()] = opts.headers[key] | ||
| } |
There was a problem hiding this comment.
Yeah, the response headers are already lowercased once parsed, but we do not handle the ones passed by the call to dispatch; those can be potentially upper cased
fixes: #3959