test: fix flaky test-grpc-packages

[santigimeno]

Summary by CodeRabbit

• Chores
  • Updated test environment prerequisites to install the latest gRPC proto-loader dependency rather than a pinned version.
  • Reduces maintenance overhead from strict version pinning and aligns test setup with current tooling.
  • No changes to application behavior or user-facing functionality; this is a development/test maintenance update.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Updated the Makefile’s test-agents-prereqs target to install the latest @grpc/proto-loader via npm instead of pinning it to version 0.7. The @grpc/grpc-js install remains unchanged. No other targets or commands were modified.

Changes

Cohort / File(s)	Summary
Build/test prerequisites Makefile	In target test-agents-prereqs, changed npm i @grpc/grpc-js @grpc/[email protected] to npm i @grpc/grpc-js @grpc/proto-loader. No other edits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• RafaelGSS
• juanarbol

Poem

I nudge the Makefile, light and neat,
Unpin a version—a tiny feat.
Proto-loader hops to latest cheer,
My whiskers twitch: “All clear here!”
With tools aligned and caches clean,
I bound ahead through build-step green. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title "test: fix flaky test-grpc-packages" is concise and directly reflects the primary intent of the change—stabilizing a flaky gRPC-related test. The Makefile change in the diff updates the npm install of @grpc/proto-loader from a pinned 0.7 to the latest, which is clearly related to gRPC packages and test flakiness. Therefore the title accurately summarizes the main change and will be understandable to reviewers scanning the history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5c219c and 609557e.

📒 Files selected for processing (1)

• Makefile (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

Makefile (2)

1693-1700: Avoid floating “latest” to keep CI deterministic; parameterize or pin versions.

Installing unpinned @grpc/grpc-js and @grpc/proto-loader makes test-agents-prereqs non-reproducible and can reintroduce flakes when those packages release. Recommend parameterizing the specs so you can set/override versions in CI, defaulting to latest only when unset.

Apply this diff within the changed line to use variables:

-env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install @grpc/grpc-js @grpc/proto-loader --prefix test/common/nsolid-grpc-agent --no-save --no-package-lock
+env npm_config_nodedir=$(PWD) $(NODE) ./deps/npm install $(GRPC_JS_SPEC) $(PROTO_LOADER_SPEC) --prefix test/common/nsolid-grpc-agent --no-save --no-package-lock

Add these variable definitions near the top (outside this hunk), so CI can pin when needed:

# Inherit from environment; when empty, installs latest.
GRPC_JS_VERSION ?=
PROTO_LOADER_VERSION ?=
GRPC_JS_SPEC := @grpc/grpc-js$(if $(GRPC_JS_VERSION),@$(GRPC_JS_VERSION),)
PROTO_LOADER_SPEC := @grpc/proto-loader$(if $(PROTO_LOADER_VERSION),@$(PROTO_LOADER_VERSION),)

---

1701-1705: Add cleanup for nsolid-grpc-agent node_modules.

test-agents-prereqs installs deps under test/common/nsolid-grpc-agent, but test-agents-prereqs-clean doesn’t remove them.

Apply this diff:

 test-agents-prereqs-clean:
 	$(RM) -r test/common/nsolid-zmq-agent/node_modules
 	$(RM) -r test/common/nsolid-otlp-agent/node_modules
+	$(RM) -r test/common/nsolid-grpc-agent/node_modules

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae1497d and c5c219c.

📒 Files selected for processing (1)

• Makefile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build-tarball
• GitHub Check: test-linux (ubuntu-24.04)
• GitHub Check: lint-js-and-md
• GitHub Check: test-macOS
• GitHub Check: test-linux (ubuntu-24.04-arm)

[juanarbol]

Nice

[santigimeno]

Landed in 45abe09