Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure POSTGRES_HOME always overrides PATH. #1

Closed

Conversation

wdh
Copy link

@wdh wdh commented Apr 26, 2018

Rebased TJC#30 onto nohuhu:improved-tests.

@wdh
Copy link
Author

wdh commented Apr 26, 2018

Test results with Postgres 9.4, 9.5 and 9.6:

[wdh@wdh Test-postgresql (make-POSTGRES_HOME-override-PATH)]$ POSTGRES_HOME=/usr/local/Cellar/postgresql\@9.4/9.4.17 prove -Ilib t/
t/00-base.t .............. ok
t/01-raii.t .............. 1/5 # PostgreSQL version: 9.4
t/01-raii.t .............. ok
t/02-multi.t ............. ok
t/04-multiprocess.t ...... ok
t/05-recycle-base-dir.t .. ok
t/06-unix-socket.t ....... ok
t/07-configs.t ........... ok
t/08-postgresql_conf.t ... ok
t/09-run_psql.t .......... ok
t/10-seed_scripts.t ...... ok
t/deadlock.t ............. 1/? # elapsed: 1
t/deadlock.t ............. ok
All tests successful.
Files=11, Tests=41, 76 wallclock secs ( 0.06 usr  0.03 sys + 23.77 cusr 15.14 csys = 39.00 CPU)
Result: PASS

[wdh@wdh Test-postgresql (make-POSTGRES_HOME-override-PATH)]$ POSTGRES_HOME=/usr/local/Cellar/postgresql\@9.5/9.5.12 prove -Ilib t/
t/00-base.t .............. ok
t/01-raii.t .............. 1/5 # PostgreSQL version: 9.5
t/01-raii.t .............. ok
t/02-multi.t ............. ok
t/04-multiprocess.t ...... ok
t/05-recycle-base-dir.t .. ok
t/06-unix-socket.t ....... ok
t/07-configs.t ........... ok
t/08-postgresql_conf.t ... ok
t/09-run_psql.t .......... ok
t/10-seed_scripts.t ...... ok
t/deadlock.t ............. 1/? # elapsed: 1
t/deadlock.t ............. ok
All tests successful.
Files=11, Tests=41, 70 wallclock secs ( 0.07 usr  0.03 sys + 21.57 cusr 12.61 csys = 34.28 CPU)
Result: PASS

[wdh@wdh Test-postgresql (make-POSTGRES_HOME-override-PATH)]$ POSTGRES_HOME=/usr/local/Cellar/postgresql\@9.6/9.6.8 prove -Ilib t/
t/00-base.t .............. ok
t/01-raii.t .............. 1/5 # PostgreSQL version: 9.6
t/01-raii.t .............. ok
t/02-multi.t ............. ok
t/04-multiprocess.t ...... ok
t/05-recycle-base-dir.t .. ok
t/06-unix-socket.t ....... ok
t/07-configs.t ........... ok
t/08-postgresql_conf.t ... ok
t/09-run_psql.t .......... ok
t/10-seed_scripts.t ...... ok
t/deadlock.t ............. 1/? # elapsed: 1
t/deadlock.t ............. ok
All tests successful.
Files=11, Tests=41, 63 wallclock secs ( 0.06 usr  0.03 sys + 18.59 cusr  9.14 csys = 27.82 CPU)
Result: PASS

nohuhu and others added 2 commits April 26, 2018 17:08
* Switching to semantic versioning; improved test diagnostics

* More fixed tests

* Add required perl version to Makefile.PL

* Ignore MANIFEST.bak

* Reverted $VERSION changes

* Pod typo

* Updated README

* Update README again

* Add a comment explaining why diag() is used in t/01-raii.t

* Code review follow-up
@wdh wdh force-pushed the make-POSTGRES_HOME-override-PATH branch from c2e996a to 9b961b8 Compare April 27, 2018 14:07
@wdh
Copy link
Author

wdh commented Apr 27, 2018

Closed in favour of TJC#31

@wdh wdh closed this Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants