Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recentUpdates): path parsing error #380

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Conversation

Nisekoi5
Copy link
Contributor

nolebase/nolebase#143
image

The missing slash is recognized as a relative path and is now added when generating the data,
should this be added when rendering?

Additionally, in a Windows environment (Node.js v18.19.0), patterns using backslashes cannot resolve files. They need to be replaced with forward slashes.

nekomeowww
nekomeowww previously approved these changes Jan 24, 2025
Copy link
Member

@nekomeowww nekomeowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@nekomeowww nekomeowww enabled auto-merge (squash) January 26, 2025 07:28
@nekomeowww nekomeowww merged commit a80efd9 into nolebase:main Jan 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants