Skip to content

Various fixes#22

Open
jpcima wants to merge 6 commits into
nomadbyte:developfrom
jpcima:misc
Open

Various fixes#22
jpcima wants to merge 6 commits into
nomadbyte:developfrom
jpcima:misc

Conversation

@jpcima

@jpcima jpcima commented May 8, 2021

Copy link
Copy Markdown

This PR contains fixes to a variety of problems.

First off, building on a current Linux system, there are many linking errors of the type "multiple definitions".
As one example, the variable float note_diff is defined in multiple sources, without the static keyword, although the use of this variable is file-local.

I went through the global variables and applied the fixes as I found appropriate.

Moreover, I've tagged global variables with a tag GLOBAL_STATE, if this is OK.
It's in order to help future efforts of porting Bristol to plugins, where the global state is a problem and it must be eventually rewritten in a more appropriate manner.

Also, const keywords where possible, fixes of bash errors, etc.

@jpcima jpcima mentioned this pull request May 8, 2021
@hfiguiere

Copy link
Copy Markdown

to fix the problem with globals, I just added this to the configure.ac after AC_SUBST(BRISTOL_HAS_OSS)

# Newer gcc require this to build
CFLAGS="$CFLAGS -fcommon"

-fno-common has become default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants