Issue 26: extended ascii char. from keyboard are ignored #28
Open
atao60 wants to merge 4 commits into
Open
Conversation
Specify the device name (amongst files under /usr/local/share/bristol/memory/profiles)
with env var PROFILE_FILE_NAME ('mini' by default)
The key mapping format is changed and now is:
KM: Extended_ASCII MIDI_note [MIDI_chan [key_code]]
If the changes are made with an editor, the file must be
saved with any ISO 8859 encoding scheme.
Nothing is changed for usual keys.
For a dead key:
- Extended_ASCII is any arbitrary character not present on the keyboard
- key_code is the code returned by the keyboard on hitting the dead key
See issue nomadbyte#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When playing notes with computer keyboard, neither extended ASCII key nor dead key can be used for mapping.
Then, e.g. with a french AZERTY keyboard, only the bottom set of keys is useful.
There are in fact two different issues:
In brightonControllers.c, inside brightonMapKeyboard method, the "from" variable must be declared "unsigned char" in place of "int".
That's it! Well almost: the profile file must be coded in some kind of iso 8859 to get extended ascii characters on one byte.
See #93 extended ascii char. from keyboard are ignored