Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement importance sampling for NoHit #1

Closed
5 of 6 tasks
nonl4331 opened this issue Oct 25, 2022 · 1 comment · Fixed by #4
Closed
5 of 6 tasks

Implement importance sampling for NoHit #1

nonl4331 opened this issue Oct 25, 2022 · 1 comment · Fixed by #4
Assignees
@nonl4331
Labels
enhancement New feature or request

Comments

@nonl4331
Copy link
Owner

nonl4331 commented Oct 25, 2022 •
edited
Loading

Description
Currently, only Primitives are able to be importance sampled. Also being able to sample NoHit which often is a source of lighting would help scenes converge faster.

Tasks

  • Discrete 1D and 2D PDF sampling
  • Tests for 1D and 2D Sampling
  • Generate 2D (UV) PDF from Texture
  • Implementation for Sky
  • Tests for NoHit sampling (for Sky)
  • MIS code
@nonl4331 nonl4331 added the enhancement New feature or request label Oct 25, 2022
@nonl4331 nonl4331 self-assigned this Oct 25, 2022
@nonl4331
Copy link
Owner Author

nonl4331 commented Oct 25, 2022 •
edited
Loading

@nonl4331 nonl4331 linked a pull request Oct 27, 2022 that will close this issue
Merge NoHit sampling #4
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nonl4331 nonl4331

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge NoHit sampling nonl4331/raytracing-rust
1 participant
@nonl4331