-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge NoHit sampling #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Importance sampling added for NoHit - MIS code modified to sample NoHit - CDF1D and CDF2D structs added - f64 feature added to force f64 use - PDF generation from texture added - NoHit trait changed to for PDF query and sampling - gui featured added to avoid bundling vulkano if not needed - Changed permute function in perlin noise to use constant - Added new tests for sky sampling and distributions - Added checking on chi2_probability function - Fixed issue where df = 0 due to pooling under certain conditions - Added from_spherical function to Vec3 - Changed classic scene to use z up
6 tasks
- Scene uses custom region allocator - clap is now used for argument handling - custom scene format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation is complete. The code may require some cleanup.