Skip to content

warn when calling broken functions that invoke UB #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

warn when calling broken functions that invoke UB #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/experimental/coroutines.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,10 @@
}
}

#[deprecated(
since = "0.4.14",
note = "this invokes undefined behaviour, see issue #723"
)]
pub fn linear<T, T1, F>(
handle: Handle<T1>,
lens: F,
Expand All @@ -337,6 +341,10 @@
}
}

#[deprecated(
since = "0.4.14",
note = "this invokes undefined behaviour, see issue #723"
)]
pub async fn follow_path<T, T1, F>(handle: Handle<T1>, mut lens: F, path: Vec<T>, time: f32)
where
T: Copy + Add<Output = T> + Sub<Output = T> + Mul<f32, Output = T>,
Expand All @@ -344,7 +352,7 @@
F: for<'r> FnMut(&'r mut T1) -> &'r mut T,
{
for point in path.windows(2) {
linear(

Check warning on line 355 in src/experimental/coroutines.rs

View workflow job for this annotation

GitHub Actions / Cross-compile (macos-latest, x86_64-apple-darwin) 

use of deprecated function `experimental::coroutines::tweens::linear`: this invokes undefined behaviour, see issue #723

Check warning on line 355 in src/experimental/coroutines.rs

View workflow job for this annotation

GitHub Actions / Cross-compile (ubuntu-latest, wasm32-unknown-unknown) 

use of deprecated function `experimental::coroutines::tweens::linear`: this invokes undefined behaviour, see issue #723

Check warning on line 355 in src/experimental/coroutines.rs

View workflow job for this annotation

GitHub Actions / Cross-compile (ubuntu-latest, x86_64-pc-windows-gnu) 

use of deprecated function `experimental::coroutines::tweens::linear`: this invokes undefined behaviour, see issue #723

Check warning on line 355 in src/experimental/coroutines.rs

View workflow job for this annotation

GitHub Actions / Cross-compile (ubuntu-latest, x86_64-unknown-linux-gnu) 

use of deprecated function `experimental::coroutines::tweens::linear`: this invokes undefined behaviour, see issue #723

Check warning on line 355 in src/experimental/coroutines.rs

View workflow job for this annotation

GitHub Actions / Cross-compile (windows-latest, x86_64-pc-windows-msvc) 

use of deprecated function `experimental::coroutines::tweens::linear`: this invokes undefined behaviour, see issue #723
handle,
&mut lens,
point[0],
Expand Down
Loading