Support more sophisticated proxy settings #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donho: What do you think? |
|
@donho, |
donho
reviewed
Sep 4, 2024
| const std::wstring& getAuth() const { return _proxyAuth; }; | ||
| void setAuth(const std::wstring& s) { _proxyAuth = s; }; | ||
| const std::wstring& getUserPass() const { return _proxyUserPass; }; | ||
| void setUserPass(const std::wstring& s) { _proxyUserPass = s; }; |
There was a problem hiding this comment.
User password shouldn't be stored into the xml file.
donho
reviewed
Sep 4, 2024
| @@ -146,7 +146,7 @@ | |||
| <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'"> | |||
| <ClCompile> | |||
| <Optimization>Disabled</Optimization> | |||
| <AdditionalIncludeDirectories>..\src\TinyXml;..\src\sha2;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories> | |||
donho
reviewed
Sep 4, 2024
|
|
||
| curl_easy_setopt(curl, CURLOPT_PROXYAUTH, lAuth); // any method as proposed by proxy | ||
| } | ||
| if (!extraOptions.getUserPass().empty()) { |
There was a problem hiding this comment.
Coding convention is not respected.
|
The KISS (Keep it Simple, Stupid) guideline should be respected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 17f2ee0
from gwinkless was giving me the right direction, but was not sufficient for my Kerberos based proxy system.
I added required parameters to treat curl as required for different constellations, trying to do as minimal changes to the rest.
@donho and @gwinkless could you check from your end if this changes are OK to release?
Regards, Mattes