Solve nonce issues #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
Added CancelAll to list of valid private methods.
Added CancelAll.
…ken-api into CristobalSalazar-patch-1
…to askmike-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some nonce issues coming back with
Error: API:Invalid nonce. I looked at the code and I saw some spoofing that influenced the resolution of thenonce. That's why I changed it to reflect the actual micro seconds.new BuffertoBuffer.from, this fixed the deprecated warning.Did some local testing. Seems to work fine.
Merged PRS #73 #69 #63.