Skip to content

Use GET request for public methods #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use GET request for public methods #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions kraken.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,26 @@ const getMessageSignature = (path, request, secret, nonce) => {
};

// Send an API request
const rawRequest = async (url, headers, data, timeout) => {
const rawRequest = async (url, headers, data, timeout, isPublic) => {
// Set custom User-Agent string
headers['User-Agent'] = 'Kraken Javascript API Client';

const options = { headers, timeout };

Object.assign(options, {
method : 'POST',
body : qs.stringify(data),
});
const queryString = qs.stringify(data);

if (isPublic){
url = `${url}?${queryString}`;
Object.assign(options, {
method : 'GET'
});
}
else {
Object.assign(options, {
method : 'POST',
body : queryString
});
}
const { body } = await got(url, options);
const response = JSON.parse(body);

Expand Down Expand Up @@ -118,7 +127,7 @@ class KrakenClient {

const path = '/' + this.config.version + '/public/' + method;
const url = this.config.url + path;
const response = rawRequest(url, {}, params, this.config.timeout);
const response = rawRequest(url, {}, params, this.config.timeout, true);

if(typeof callback === 'function') {
response
Expand Down Expand Up @@ -168,7 +177,7 @@ class KrakenClient {
'API-Sign' : signature,
};

const response = rawRequest(url, headers, params, this.config.timeout);
const response = rawRequest(url, headers, params, this.config.timeout, false);

if(typeof callback === 'function') {
response
Expand Down