chore: upgrade to ENSv2 (Universal Resolver) - #1286
Open
Dhaiwat10 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I'm Dhaiwat from the DevRel team at ENS Labs. We're working on getting active repos and libraries across the ecosystem ready for ENSv2.
Summary
Upgrades this repo to be ENSv2-ready by routing ENS resolution through the Universal Resolver (
0xeeeeeeee14d718c2b47d9923deab1335e144eeee) instead of the legacy ENS Registry.Changes
viementry inpnpm-workspace.yaml's catalog from^2.33.0→^2.48.11(Universal Resolver + CCIP-Read built in from 2.35.0). Workspace packages continue to reference"viem": "catalog:"so the catalog convention is preserved.viem(viawagmi) is used for ENS at:packages/nouns-webapp/src/components/ShortAddress.tsx(useEnsName,useEnsAvatar)packages/nouns-webapp/src/components/ChangeDelegatePanel/index.tsx:94(useEnsAddress— resolvesvitalik.ethstyle input before delegating, where a stale resolution would route to the wrong address)packages/nouns-webapp/src/components/VoteSignals/VoteSignal.tsx(useEnsName)Why
The current path returns stale results for names managed by the new Universal Resolver. For example,
ur.integration-tests.ethshould resolve to0x2222222222222222222222222222222222222222; legacy resolution returns incorrect values.More details: https://docs.ens.domains/web/ensv2-readiness
Verification
ur.integration-tests.eth→0x2222222222222222222222222222222222222222