Skip to content

Enable attaching the control bar to top and bottom#2043

Open
tobfah wants to merge 4 commits intonovnc:masterfrom
tobfah:enable-horizontal-control-bar
Open

Enable attaching the control bar to top and bottom#2043
tobfah wants to merge 4 commits intonovnc:masterfrom
tobfah:enable-horizontal-control-bar

Conversation

@tobfah
Copy link
Copy Markdown

@tobfah tobfah commented Feb 18, 2026

This PR enables attaching the control bar to the top and bottom positions, in addition to the traditional left and right positions.

Tested on

  • Fedora 42
    • Firefox 147
    • Chromium 144
  • macOS 26.3
    • Safari 26.3
    • Chrome 144
  • Win 11
    • Edge 145
  • Android 13
    • Chrome 144
  • iPad 26.3
    • Safari 26.3

@CendioHanli
Copy link
Copy Markdown

Tested the implementation on Epiphany v40.2 and Chromium v144 on Fedora 43 and found no issues. Regarding the decision to not use a relative offset for the noVNC_control_bar in the top and bottom positions look good. I found no instance where this caused any weird edge cases.
LGTM!

Copy link
Copy Markdown
Member

@samhed samhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funkar bra, har testat på Chrome (Linux) och Firefox (Android), mycket trevlig funktion!

Ifall slutresultatet är tänkt att ha uppdelade commits bör du nog nämna i alla commits vilken relation de har till huvudproblemet.

Comment thread app/ui.js Outdated
Comment thread vnc.html
@samhed samhed modified the milestones: v1.7.0, v1.8.0 Mar 24, 2026
@tobfah tobfah force-pushed the enable-horizontal-control-bar branch from 3b0ba39 to cea37c8 Compare March 27, 2026 12:59
In preparation for horizontal control bar modes
@tobfah tobfah force-pushed the enable-horizontal-control-bar branch 2 times, most recently from b9c18a0 to 9c9bfb9 Compare April 2, 2026 11:33
@tobfah
Copy link
Copy Markdown
Author

tobfah commented Apr 2, 2026

I've restructured the PR a bit. A few changes since the initial one:

  • The default left position returns as an implicit fallback for robustness (noVNC_left reverted)
  • Rely less on local storage
  • Separation of commits have been simplified and should make more sense on their own

Not sure why clipboard tests keep failing though.

Tobias added 3 commits April 3, 2026 12:49
Simplifies alignment. In preparation for horizontal control bar modes.
There's only one button in the group, and the wrapping div messed with
the flex box layout
@tobfah tobfah force-pushed the enable-horizontal-control-bar branch from 9c9bfb9 to 052242d Compare April 3, 2026 10:51
@tobfah
Copy link
Copy Markdown
Author

tobfah commented Apr 8, 2026

The last force push fixed some alignment issues with the handle arrow when control bar is in horizontal modes (top/bottom).

I've ran the tests on a RHEL 10.1 with nodejs 22.22.0 and npm 10.9.4, and they all pass on my side, so I'm not sure what to do with those that keep failing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dock 'noVNC' control box on either top/bottom of the window rather than left/right only

3 participants