Enable attaching the control bar to top and bottom#2043
Enable attaching the control bar to top and bottom#2043tobfah wants to merge 4 commits intonovnc:masterfrom
Conversation
edbef63 to
3b0ba39
Compare
|
Tested the implementation on Epiphany v40.2 and Chromium v144 on Fedora 43 and found no issues. Regarding the decision to not use a relative offset for the |
samhed
left a comment
There was a problem hiding this comment.
Funkar bra, har testat på Chrome (Linux) och Firefox (Android), mycket trevlig funktion!
Ifall slutresultatet är tänkt att ha uppdelade commits bör du nog nämna i alla commits vilken relation de har till huvudproblemet.
3b0ba39 to
cea37c8
Compare
In preparation for horizontal control bar modes
b9c18a0 to
9c9bfb9
Compare
|
I've restructured the PR a bit. A few changes since the initial one:
Not sure why clipboard tests keep failing though. |
Simplifies alignment. In preparation for horizontal control bar modes.
There's only one button in the group, and the wrapping div messed with the flex box layout
9c9bfb9 to
052242d
Compare
|
The last force push fixed some alignment issues with the handle arrow when control bar is in horizontal modes (top/bottom). I've ran the tests on a RHEL 10.1 with nodejs 22.22.0 and npm 10.9.4, and they all pass on my side, so I'm not sure what to do with those that keep failing here. |
This PR enables attaching the control bar to the top and bottom positions, in addition to the traditional left and right positions.
Tested on