echo back requested Sec-Websocket-Protocol header for better browser …#24
Open
tsingakbar wants to merge 1 commit intonovnc:masterfrom
Open
echo back requested Sec-Websocket-Protocol header for better browser …#24tsingakbar wants to merge 1 commit intonovnc:masterfrom
tsingakbar wants to merge 1 commit intonovnc:masterfrom
Conversation
Member
|
Thank you for your contribution. There appears to be some unrelated changes in this commit as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…compatibility.
background
The novnc web version we are using will construct websocket object with protocol argument, which will result in the request sent by browser contains a Sec-Websocket-Protocol.
The golang implement won't bring it back in response header, then some browsers(chrome especially) will judge that the websocket server doesn't support the requested websocket subprotocols, and furthur close the connection.