Skip to content

docs(ui): add stories for Privacy page#2319

Merged
ghostdevv merged 3 commits intonpmx-dev:mainfrom
cylewaitforit:sb-privacy-page
Apr 4, 2026
Merged

docs(ui): add stories for Privacy page#2319
ghostdevv merged 3 commits intonpmx-dev:mainfrom
cylewaitforit:sb-privacy-page

Conversation

@cylewaitforit
Copy link
Copy Markdown
Contributor

@cylewaitforit cylewaitforit commented Mar 29, 2026

🔗 Linked issue

#2150

🧭 Context

This would also enable a storybook mock page, storybook a11y checks, and chromatic visual regression tests for this page as documented by the storybook stories.

📚 Description

Adds stories for Privacy page.

Creates shared pagesDecorator to reduce duplication in stories.

https://698b88d5157d89f1f33a6c21-hffnzxcven.chromatic.com/?path=/story/pages-privacy--default

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Apr 4, 2026 6:29pm
npmx.dev Ready Ready Preview, Comment Apr 4, 2026 6:29pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Apr 4, 2026 6:29pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: da5e9083-250f-43b7-95ab-6107b1e8677c

📥 Commits

Reviewing files that changed from the base of the PR and between 2a912fb and a2f9478.

📒 Files selected for processing (3)
  • app/pages/about.stories.ts
  • app/pages/accessibility.stories.ts
  • app/pages/privacy.stories.ts
✅ Files skipped from review due to trivial changes (1)
  • app/pages/privacy.stories.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/pages/about.stories.ts

📝 Walkthrough

Walkthrough

A new shared pageDecorator was created in .storybook/decorators.ts that provides a standardised page layout wrapper for Storybook stories, composing AppHeader and AppFooter components around story content with consistent full-height flexbox styling and focus management. Multiple existing story files (about.stories.ts and accessibility.stories.ts) were refactored to use this shared decorator instead of duplicating inline implementations. A new story file (privacy.stories.ts) was added for the privacy page component, also utilising the shared decorator pattern.

Possibly related PRs

Suggested reviewers

  • alexdln
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the addition of Storybook stories for the Privacy page and the creation of a shared pageDecorator to reduce duplication.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! love having chromatic for more pages 🫡

@ghostdevv ghostdevv enabled auto-merge April 4, 2026 18:27
@ghostdevv ghostdevv disabled auto-merge April 4, 2026 18:27
@ghostdevv ghostdevv enabled auto-merge April 4, 2026 18:30
@ghostdevv ghostdevv added this pull request to the merge queue Apr 4, 2026
Merged via the queue into npmx-dev:main with commit 65d81bd Apr 4, 2026
20 checks passed
@cylewaitforit cylewaitforit deleted the sb-privacy-page branch April 4, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants