next #315
Closed
next #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| #include <hw_id.h> | |||
|
|
|||
| #define MODULE main | |||
| #include "module_state_event.h" | |||
| #include "module_state_event" | |||
|
|
|||
| #include <zephyr/logging/log.h> | |||
| LOG_MODULE_REGISTER(MODULE); | |||
There was a problem hiding this comment.
- The header file "module_state_event.h" has been changed to "module_state_event", which may lead to issues if the new name does not correspond to an existing file.
| @@ -94,7 +94,7 @@ void emberAfClusterInitCallback(EndpointId endpoint, ClusterId clusterId) | |||
| } | |||
| } | |||
|
|
|||
| void __attribute__((weak)) emberAfAccessControlClusterInitCallback(EndpointId endpoint) | |||
| void __attribute__((weak)) emberAfAccessControlClusterInitCallback(EndpointId endpoint, int source) | |||
| { | |||
| // To prevent warning | |||
| (void)endpoint; | |||
There was a problem hiding this comment.
- The function
emberAfClusterInitCallbackhas an incorrect parameter type forsource, it should beint sourceinstead ofsource int. - The function
emberAfAccessControlClusterInitCallbackhas an inconsistent parameter list compared to its previous definition, which could lead to compatibility issues.
| @@ -44,6 +44,7 @@ | |||
|
|
|||
| /**** Cluster Plugins ****/ | |||
|
|
|||
| // Use this macro to check if the server side of the Identify cluster is included | |||
| // Use this macro to check if the server side of the Identify cluster is included | |||
| #define ZCL_USING_IDENTIFY_CLUSTER_SERVER | |||
| #define MATTER_DM_PLUGIN_IDENTIFY_SERVER | |||
There was a problem hiding this comment.
- The pragma directive was incorrectly changed from
#pragma onceto#pragma twice, which may lead to multiple inclusions of the header file. - There is a duplicate comment regarding checking if the server side of the Identify cluster is included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.