GPT test #317
Closed
GPT test #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| @@ -10,7 +10,7 @@ | |||
| #include <hw_id.h> | |||
|
|
|||
| #define MODULE main | |||
| #include "module_state_event.h" | |||
| #include "module_state_event" | |||
|
|
|||
| #include <zephyr/logging/log.h> | |||
| LOG_MODULE_REGISTER(MODULE); | |||
There was a problem hiding this comment.
- The header file included has mismatched naming; it should match the actual file name including the extension (
.h).
| @@ -94,7 +94,7 @@ void emberAfClusterInitCallback(EndpointId endpoint, ClusterId clusterId) | |||
| } | |||
| } | |||
|
|
|||
| void __attribute__((weak)) emberAfAccessControlClusterInitCallback(EndpointId endpoint) | |||
| void __attribute__((weak)) emberAfAccessControlClusterInitCallback(EndpointId endpoint, int source) | |||
| { | |||
| // To prevent warning | |||
| (void)endpoint; | |||
There was a problem hiding this comment.
- The function
emberAfClusterInitCallbackhas an incorrect parameter typesource int; it should beint source.
| @@ -44,6 +44,7 @@ | |||
|
|
|||
| /**** Cluster Plugins ****/ | |||
|
|
|||
| // Use this macro to check if the server side of the Identify cluster is included | |||
| // Use this macro to check if the server side of the Identify cluster is included | |||
| #define ZCL_USING_IDENTIFY_CLUSTER_SERVER | |||
| #define MATTER_DM_PLUGIN_IDENTIFY_SERVER | |||
There was a problem hiding this comment.
- The pragma directive has been changed from
#pragma onceto#pragma twice, which is likely incorrect as#pragma twiceis not a standard directive.
| @@ -143,7 +144,7 @@ static void uart_rx_handler(uint8_t character) | |||
|
|
|||
| return; | |||
| send: | |||
| /* Terminate the command string */ | |||
| /* Termnate the command string */ | |||
| at_buf[at_cmd_len] = '\0'; | |||
|
|
|||
| /* Reset UART handler state */ | |||
There was a problem hiding this comment.
- There is a duplicate inclusion of the
<string.h>header file. - The function return type for
cmd_sendwas changed fromvoidtoint, which may require adjustments in calling functions. - There is an extra semicolon after the
}in theuart_rx_handlerfunction which is unnecessary and could lead to confusion. - There is a typo in the comment that states "Termnate" instead of "Terminate".
| @@ -55,7 +55,7 @@ int bl_secp256r1_validate(const uint8_t *hash, uint32_t hash_len, | |||
| case CRYS_ECDSA_VERIFY_INVALID_SIGNATURE_IN_PTR_ERROR: | |||
| case CRYS_ECDSA_VERIFY_INVALID_MESSAGE_DATA_IN_PTR_ERROR: | |||
| case CRYS_ECDSA_VERIFY_INVALID_MESSAGE_DATA_IN_SIZE_ERROR: | |||
| return -EINVAL; | |||
| return -EINVAL; | |||
| case CRYS_ECDSA_VERIFY_INCONSISTENT_VERIFY_ERROR: | |||
| return -ESIGINV; | |||
| default: | |||
There was a problem hiding this comment.
- The definition of
CRYS_ECDSA_VERIFY_INVALID_MESSAGE_DATA_IN_SIZE_ERRORhas changed its error code from0x81ULto0x161UL, which may lead to inconsistency or breaking changes if not all references are updated accordingly.
thst-nordic
reviewed
Feb 18, 2025
| @@ -143,7 +144,7 @@ static void uart_rx_handler(uint8_t character) | |||
|
|
|||
| return; | |||
| send: | |||
| /* Terminate the command string */ | |||
| /* Termnate the command string */ | |||
There was a problem hiding this comment.
Suggested change
| /* Termnate the command string */ | |
| /* Terminate the command string */ |
thst-nordic
reviewed
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.