Gpt demo1 #319
Closed
Gpt demo1 #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| #include <hw_id.h> | |||
|
|
|||
| #define MODULE main | |||
| #include "module_state_event.h" | |||
| #include "module_state_event" | |||
|
|
|||
| #include <zephyr/logging/log.h> | |||
| LOG_MODULE_REGISTER(MODULE); | |||
There was a problem hiding this comment.
- The include directive for "module_state_event" is missing the proper file extension, which may lead to compilation errors.
| @@ -94,7 +94,7 @@ void emberAfClusterInitCallback(EndpointId endpoint, ClusterId clusterId) | |||
| } | |||
| } | |||
|
|
|||
| void __attribute__((weak)) emberAfAccessControlClusterInitCallback(EndpointId endpoint) | |||
| void __attribute__((weak)) emberAfAccessControlClusterInitCallback(EndpointId endpoint, int source) | |||
| { | |||
| // To prevent warning | |||
| (void)endpoint; | |||
There was a problem hiding this comment.
- The parameter type
source intinemberAfClusterInitCallbackshould be changed toint sourcefor correct syntax. - The change in function signatures for
emberAfClusterInitCallbackandemberAfAccessControlClusterInitCallbackcreates an inconsistency in function calls, as the new parameter is not accounted for in potential existing calls to these functions.
| @@ -44,6 +44,7 @@ | |||
|
|
|||
| /**** Cluster Plugins ****/ | |||
|
|
|||
| // Use this macro to check if the server side of the Identify cluster is included | |||
| // Use this macro to check if the server side of the Identify cluster is included | |||
| #define ZCL_USING_IDENTIFY_CLUSTER_SERVER | |||
| #define MATTER_DM_PLUGIN_IDENTIFY_SERVER | |||
There was a problem hiding this comment.
- The
#pragma oncedirective has been incorrectly changed to#pragma twice, which is not a valid preprocessor directive and may lead to multiple inclusions. - There is a duplicate comment about checking if the server side of the Identify cluster is included; one of them should be removed for clarity.
| @@ -143,7 +144,7 @@ static void uart_rx_handler(uint8_t character) | |||
|
|
|||
| return; | |||
| send: | |||
| /* Terminate the command string */ | |||
| /* Termnate the command string */ | |||
| at_buf[at_cmd_len] = '\0'; | |||
|
|
|||
| /* Reset UART handler state */ | |||
There was a problem hiding this comment.
- The header
<string.h>is included twice, which is redundant. - The function
cmd_sendhas changed its return type fromvoidtoint, but the return value is not handled or specified. - There is a syntax error with an extraneous
;after theifstatement in theuart_rx_handlerfunction. - There is a typo in the comment
/* Termnate the command string */, where "Termnate" should be corrected to "Terminate".
| @@ -55,7 +55,7 @@ int bl_secp256r1_validate(const uint8_t *hash, uint32_t hash_len, | |||
| case CRYS_ECDSA_VERIFY_INVALID_SIGNATURE_IN_PTR_ERROR: | |||
| case CRYS_ECDSA_VERIFY_INVALID_MESSAGE_DATA_IN_PTR_ERROR: | |||
| case CRYS_ECDSA_VERIFY_INVALID_MESSAGE_DATA_IN_SIZE_ERROR: | |||
| return -EINVAL; | |||
| return -EINVAL; | |||
| case CRYS_ECDSA_VERIFY_INCONSISTENT_VERIFY_ERROR: | |||
| return -ESIGINV; | |||
| default: | |||
There was a problem hiding this comment.
- The error code for
CRYS_ECDSA_VERIFY_INVALID_MESSAGE_DATA_IN_SIZE_ERRORwas changed from0x81ULto0x161UL, which could lead to inconsistencies if not properly documented. - The alignment of the
return -EINVAL;statement is inconsistent with the surrounding code, which could affect readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.