-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Mesh: Store comp data hash as Number in JSON file #20449
Bluetooth: Mesh: Store comp data hash as Number in JSON file #20449
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: c0c95ecd0bd11319a6b15b7ed96f5298defce34c more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)
Outputs:ToolchainVersion: 0f22b642ed Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine with me.
Btw ... it is 32 bit "unsigned" integer. |
Sure, I guess this only affects the commit message? The handling of this is already doing unsigned using |
The comp data hash is an integer (32-bit unsigned integer), and, like other integers in the JSON file (CID, PID, etc. for instance), should be stored as a number in the JSON file, not a hex-encoded string. Signed-off-by: Ludvig Jordet <[email protected]>
c11978b
to
c0c95ec
Compare
The comp data hash is an integer (32-bit unsigned integer), and, like other integers in the JSON file (CID, PID, etc. for instance), should be stored as a number in the JSON file, not a hex-encoded string.