Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Add checks for consistency of signing configuration #20461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahasztag
Copy link
Contributor

It is checked whether the sign Kconfig options and the MPI configurations are consistent. A verbose error is issued if they are not.

@ahasztag ahasztag requested review from a team as code owners February 18, 2025 14:06
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 18, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@2e22c17 nrfconnect/suit-generator#173 nrfconnect/suit-generator#173/files

DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 18, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 44533d1679da4a8b5e98748ec661587cb5d478c9
suit-generator: PR head: e3c78cb338fa31f94afa8caac4c03f5fe3ad4131

more details

sdk-nrf:

PR head: 44533d1679da4a8b5e98748ec661587cb5d478c9
merge base: f195846dd804cd7ee3f4881ddcb3d0de99e7de74
target head (main): f195846dd804cd7ee3f4881ddcb3d0de99e7de74
Diff

suit-generator:

PR head: e3c78cb338fa31f94afa8caac4c03f5fe3ad4131
merge base: 2e22c176ba50930604519c3f70ee8ae5ba2a09ac
target head (main): 0a8712aa142490deb02ca39c4bb150c70c66f835
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (29)
config
│  ├── suit
│  │  ├── macros
│  │  │  │ consistency_checks.jinja
│  │  ├── templates
│  │  │  ├── nrf54h20
│  │  │  │  ├── default
│  │  │  │  │  ├── v1
│  │  │  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  │  │  ├── app_recovery_envelope_app_local.yaml.jinja2
│  │  │  │  │  │  ├── app_recovery_envelope_direct.yaml.jinja2
│  │  │  │  │  │  ├── app_recovery_local_envelope.yaml.jinja2
│  │  │  │  │  │  ├── rad_envelope.yaml.jinja2
│  │  │  │  │  │  ├── rad_recovery_envelope.yaml.jinja2
│  │  │  │  │  │  │ root_with_binary_nordic_top.yaml.jinja2
│  │  │  │  ├── matter
│  │  │  │  │  ├── v1
│  │  │  │  │  │  ├── app_envelope.yaml.jinja2
│  │  │  │  │  │  ├── rad_envelope.yaml.jinja2
│  │  │  │  │  │  │ root_with_binary_nordic_top.yaml.jinja2
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── ncs
│  │  │  │  ├── Kconfig
│  │  │  │  ├── build.py
│  │  │  │  ├── encrypt_script.py
│  │  │  │  │ sign_script.py
│  │  │  ├── suit_generator
│  │  │  │  ├── cmd_encrypt.py
│  │  │  │  ├── cmd_sign.py
│  │  │  │  │ suit_sign_script_base.py
│  │  │  ├── tests
│  │  │  │  ├── encrypt_script_mock.py
│  │  │  │  ├── kms_script_mock.py
│  │  │  │  ├── sign_script_mock.py
│  │  │  │  ├── test_cmd_encrypt.py
│  │  │  │  ├── test_cmd_sign.py
│  │  │  │  ├── test_ncs_encrypt_script.py
│  │  │  │  │ test_ncs_sign_script.py
samples
│  ├── suit
│  │  ├── smp_transfer
│  │  │  ├── suit
│  │  │  │  ├── nrf54h20
│  │  │  │  │  ├── app_envelope_extflash.yaml.jinja2
│  │  │  │  │  ├── rad_envelope_extflash.yaml.jinja2
│  │  │  │  │  │ root_with_binary_nordic_top_extflash.yaml.jinja2
west.yml

Outputs:

Toolchain

Version: 0f22b642ed
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:0f22b642ed_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 171
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@ahasztag ahasztag force-pushed the consistency_checks_in_manifests_templates branch from 0b3013e to ef1e20e Compare February 18, 2025 15:05
It is checked whether the sign Kconfig options and the
MPI configurations are consistent. A verbose error
is issued if they are not.

Signed-off-by: Artur Hadasz <[email protected]>
@ahasztag ahasztag force-pushed the consistency_checks_in_manifests_templates branch from ef1e20e to 44533d1 Compare February 19, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-suit-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants