Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: bluetooth: hids: Enable TF-M profile small for /ns target #20468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkapala-nordic
Copy link
Contributor

Enabled the CONFIG_TFM_PROFILE_TYPE_SMALL for the
nrf5340dk/nrf5340/cpuapp/ns as it is required for the Bluetooth stack to work properly as it now uses the PSA crypto API.

Jira: NCSDK-31777

@mkapala-nordic mkapala-nordic requested a review from a team as a code owner February 18, 2025 14:55
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 18, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 12d6b8474ae5fd511da91069565b7805e78b9681

more details

sdk-nrf:

PR head: 12d6b8474ae5fd511da91069565b7805e78b9681
merge base: 2978b4f72bab7d69e75db054605bc1d0674dd4ba
target head (main): 14ec94673be0936ae6b011f3713457e0b9f53f81
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── central_hids
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.conf
│  │  ├── peripheral_hids_keyboard
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.conf
│  │  ├── peripheral_hids_mouse
│  │  │  ├── boards
│  │  │  │  │ nrf5340dk_nrf5340_cpuapp_ns.conf

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 493
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nfc
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@MarekPieta MarekPieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to enable TF-M profile other than minimal globally by default if Bluetooth is used (e.g. by overlying Kconfig defaults). Then Bluetooth samples would work out-of-the box for NS targets with TF-M and user could still optimize it further if needed.

@mkapala-nordic mkapala-nordic force-pushed the upmerge/20241220/post-cleanup-ns-targets-fix branch from bb99235 to 41f7097 Compare February 20, 2025 13:52
@mkapala-nordic mkapala-nordic requested a review from a team as a code owner February 20, 2025 13:52
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20468/nrf/releases_and_maturity/releases/release-notes-changelog.html

@@ -286,6 +286,15 @@ Bluetooth samples
* :ref:`bluetooth_central_hids`
* :ref:`peripheral_hids_keyboard`

* Updated the non-secure target ``nrf5340dk/nrf5340/cpuapp/ns`` configurations of the following samples to properly configure the TF-M profile instead of using the predefined minimal TF-M profile:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Updated the non-secure target ``nrf5340dk/nrf5340/cpuapp/ns`` configurations of the following samples to properly configure the TF-M profile instead of using the predefined minimal TF-M profile:
* Updated the configurations of the non-secure ``nrf5340dk/nrf5340/cpuapp/ns`` board target in the following samples to properly use the TF-M profile instead of the predefined minimal TF-M profile:

Enabled the CONFIG_TFM_PROFILE_TYPE_SMALL for the
nrf5340dk/nrf5340/cpuapp/ns as it is required for the Bluetooth
stack to work properly as it now uses the PSA crypto API.

Jira: NCSDK-31777

Signed-off-by: Mateusz Kapala <[email protected]>
@mkapala-nordic mkapala-nordic force-pushed the upmerge/20241220/post-cleanup-ns-targets-fix branch 2 times, most recently from 2c7398e to 12d6b84 Compare February 20, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants